Skip to content

CTA links now use text underlines instead of borders (#490)#492

Merged
stephaniehobson merged 1 commit intomozilla:masterfrom
stephaniehobson:cta
Oct 9, 2019
Merged

CTA links now use text underlines instead of borders (#490)#492
stephaniehobson merged 1 commit intomozilla:masterfrom
stephaniehobson:cta

Conversation

@stephaniehobson
Copy link
Copy Markdown
Contributor

@stephaniehobson stephaniehobson commented Sep 23, 2019

Description

CTA links now use text underlines instead of borders

  • I have documented this change in the design system.
  • I have recorded this change in CHANGELOG.md.

Issue

Fix #490

Testing

@stephaniehobson stephaniehobson added Needs:Review 👋 Ready for Developer Review P3 Third level priority - Nice to have Review: XS Code review time: 30 mins or less labels Sep 23, 2019
craigcook
craigcook approved these changes Oct 4, 2019
View reviewed changes
Copy link
Copy Markdown
Contributor

@craigcook craigcook left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🐗

@stephaniehobson stephaniehobson merged commit 9a0eb5e into mozilla:master Oct 9, 2019
@stephaniehobson stephaniehobson deleted the cta branch October 9, 2019 00:17
@stephaniehobson stephaniehobson removed the Needs:Review 👋 Ready for Developer Review label Oct 9, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@craigcook craigcook craigcook approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

P3 Third level priority - Nice to have Review: XS Code review time: 30 mins or less

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Component Change Request: cta-link

2 participants

@stephaniehobson @craigcook