Skip to content

Use window.Mzp in Modal and Notification components#496

Merged
alexgibson merged 1 commit intomozilla:masterfrom
liamnewmarch:master
Sep 27, 2019
Merged

Use window.Mzp in Modal and Notification components#496
alexgibson merged 1 commit intomozilla:masterfrom
liamnewmarch:master

Conversation

@liamnewmarch
Copy link
Copy Markdown
Contributor

Hi @alexgibson this is a continuation of #488 – in updating my fork accidentally closed that PR and now GH won’t let me add new commits to it. Sorry about that, and thanks for taking a look.

As requested:

  • I have recorded this change in CHANGELOG.md.

Copy link
Copy Markdown
Contributor

@alexgibson alexgibson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks for the update!

@alexgibson alexgibson merged commit 1f0b7dc into mozilla:master Sep 27, 2019
@alexgibson
Copy link
Copy Markdown
Contributor

alexgibson commented Sep 27, 2019

I'll see if we can publish a new NPM release for you. I'll update here once that has happened.

@alexgibson alexgibson mentioned this pull request Sep 27, 2019
1 task
@liamnewmarch
Copy link
Copy Markdown
Contributor Author

Amazing, thanks Alex

@alexgibson
Copy link
Copy Markdown
Contributor

9.0.1 is now published with your fix: https://www.npmjs.com/package/@mozilla-protocol/core

Thanks for contributing 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants