Use window.Mzp in Modal and Notification components#496
Merged
alexgibson merged 1 commit intomozilla:masterfrom Sep 27, 2019
Merged
Use window.Mzp in Modal and Notification components#496alexgibson merged 1 commit intomozilla:masterfrom
alexgibson merged 1 commit intomozilla:masterfrom
Conversation
alexgibson
approved these changes
Sep 27, 2019
Contributor
alexgibson
left a comment
There was a problem hiding this comment.
Looks good, thanks for the update!
Contributor
|
I'll see if we can publish a new NPM release for you. I'll update here once that has happened. |
Contributor
Author
|
Amazing, thanks Alex |
Contributor
|
9.0.1 is now published with your fix: https://www.npmjs.com/package/@mozilla-protocol/core Thanks for contributing 🎉 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi @alexgibson this is a continuation of #488 – in updating my fork accidentally closed that PR and now GH won’t let me add new commits to it. Sorry about that, and thanks for taking a look.
As requested:
CHANGELOG.md.