Use window.Mzp in Modal and Notification components#488
Closed
liamnewmarch wants to merge 0 commit intomozilla:masterfrom
Closed
Use window.Mzp in Modal and Notification components#488liamnewmarch wants to merge 0 commit intomozilla:masterfrom
liamnewmarch wants to merge 0 commit intomozilla:masterfrom
Conversation
stephaniehobson
added
Needs:Review 👋
Contributor
Author
|
Bump! Is anyone able to review this? If so, it would be helpful in unblocking something we’re working on. |
alexgibson
suggested changes
Sep 27, 2019
Contributor
alexgibson
left a comment
alexgibson
left a comment
There was a problem hiding this comment.
Code changes look fine, but please record this in the changelog.
I can help publish a new release on NPM so this can unblock you. Thanks for the PR!
liamnewmarch
force-pushed
the
master
branch
from
5b1c29d to
afad69e
Compare
liamnewmarch
added a commit
to liamnewmarch/protocol
that referenced
this pull request
Sep 27, 2019
1 task
Contributor
Author
|
Pushing new commits isn’t working here so I’ve opened #496 instead, sorry about that! |
alexgibson
pushed a commit
that referenced
this pull request
Sep 27, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In github.com/mdn/developer-portal we are using Webpack to include Protocol components in our bundle.
In this setup, each component is wrapped in a function which means we can't rely on the
var Mzpcheck at the top of each file to create an implicit global – in our case the variable that is created is scoped to the module. This doesn’t matter for most components because assign something towindow.Mzp, but Modal and Notification Bar use the module-scopedMzpvariable instead.This PR changes that assignment, so Modal and Notification Bar use
window.Mzp, as well as other small changes for consistency with the rest of the components.