Merged
Conversation
craigcook
added
Needs:Review 👋
stephaniehobson
approved these changes
Mar 19, 2020
Contributor
stephaniehobson
left a comment
stephaniehobson
left a comment
There was a problem hiding this comment.
R+ the way it is. Nice #a11y improvements.
We could optionally display the focus styles on hover as well.
| text-align: center; | ||
|
|
||
| @media #{$mq-sm} { | ||
| min-width: $content-sm; |
Fixes mozilla#549 - use border-box Fix image replacement bug Add focus styles Tweak spacing
craigcook
force-pushed
the
549-notification-bar
branch
from
6b34a51 to
de1ca8a
Compare
2 tasks
craigcook
added a commit
that referenced
this pull request
May 8, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes #549 - use border-box
Fix image replacement bug
Add focus styles
Tweak spacing
CHANGELOG.md.Issue
#549