Skip to content

center the notification bar in larger viewports#570

Merged
stephaniehobson merged 1 commit intomozilla:masterfrom
craigcook:notification-bar
Apr 21, 2020
Merged

center the notification bar in larger viewports#570
stephaniehobson merged 1 commit intomozilla:masterfrom
craigcook:notification-bar

Conversation

@craigcook
Copy link
Contributor

@craigcook craigcook commented Apr 21, 2020

Description

When updating the notification bar in #553 I left out a rule to center it in the viewport when it's non-sticky. D'oh!

  • I have documented this change in the design system.
  • I have recorded this change in CHANGELOG.md.

@craigcook craigcook added Needs:Review 👋 Ready for Developer Review Review: µ Code review time: 5 minutes or less labels Apr 21, 2020
Copy link
Contributor

@stephaniehobson stephaniehobson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

R+ ↔️

@stephaniehobson stephaniehobson merged commit 548e7ce into mozilla:master Apr 21, 2020
@craigcook craigcook deleted the notification-bar branch April 21, 2020 20:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Needs:Review 👋 Ready for Developer Review Review: µ Code review time: 5 minutes or less

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants