This repository was archived by the owner on Oct 28, 2020. It is now read-only.
[fix bug 980140] Add goals field in events.#671
Merged
Conversation
Contributor
|
I have taken a look and this PR seems to work fine. I have some thoughts about the icon in the edit event page. @alexgibson Any thoughts? |
Contributor
|
A couple of minor nits, but front-end looks fine to me r+wc. 🚀 As discussed on IRC, we are going to opt for the 'medal' icon for the goals button. |
Contributor
|
Just a heads up: We need to have event goals in the DB by the time we launch this feature, else users cannot edit events since this field is required. |
Contributor
|
Also we need to make sure that we have event goals available for old events as well, in case someone edits an old event. |
Contributor
There was a problem hiding this comment.
It might be useful to register the EventGoal model in admin except of that inline in events.
Contributor
|
r+wc 🐰 |
akatsoulas
added a commit
that referenced
this pull request
Mar 20, 2014
[fix bug 980140] Add goals field in events.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.