Test262 update#1986
Conversation
|
sorry will fix that tomorrow.... |
|
Interesting -- can we add to the commit message why we are changing this -- since we don't support "upsert" yet, it allows more test cases to run, yes? |
|
oh, there was no real reasoning behind, i was curious to figure out if i'm able to do the update at all. And as second step i tried to figure out how many of the tests are failing because of const in lool (only some). Another Motivation was the #1397. Will try to get in contact with @camnwalter to see if we can do this together. |
|
I'm going to be travelling an bit and won't keep up with the sudden increase in PR volume (thanks everyone!) You are free to merge this and other things that you are happy with! |
|
@gbrail, @andreabergia @anivar have done a bunch of updates (see the description on top). Please have a look.... |
| prototype/getOrInsert/returns-value-normalized-zero-key.js | ||
| built-ins/Map 35/204 (17.16%) | ||
| prototype/getOrInsertComputed 19/19 (100.0%) | ||
| prototype/getOrInsert 14/14 (100.0%) |
There was a problem hiding this comment.
How should this be interpreted?
Before: 10 tests in the prototype/getOrInsert were failing (and at least one passing)
Now: all tests in the prototype/getOrInsert are failing.
Is this the correct interpetion?
|
|
||
| built-ins/NativeErrors 36/139 (25.9%) | ||
| AggregateError/newtarget-proto-fallback.js | ||
| AggregateError/proto-from-ctor-realm.js |
There was a problem hiding this comment.
I assume, that these tests are now removed, because AggregateError is an unsupported feature?
| prototype/getOrInsert/returns-value-if-key-is-not-present-object-key.js | ||
| prototype/getOrInsert/returns-value-if-key-is-not-present-symbol-key.js | ||
| prototype/getOrInsert/returns-value-if-key-is-present-object-key.js | ||
| prototype/getOrInsert/returns-value-if-key-is-present-symbol-key.js |
There was a problem hiding this comment.
I'm not 100% sure, if I got it, but a removed line means, that the test is no longer excluded and will pass now?
Can you explain me, why an update of the test262 with nearly no other code changes lets them pass now?
Am I missing something or was the file not up-to-date on master?
There was a problem hiding this comment.
I'm not 100% sure, if I got it, but a removed line means, that the test is no longer excluded and will pass now?
excluded things are marked with a ~ in front, all explicit listed tests are executed and failing. Will have a look at these - but keep in mind i only have regenerated the file (and added some more folder)
There was a problem hiding this comment.
See below, the diff is a bit confusing because i have added the Uint8Array tests.
The tests still failing, the new WeakMap section i below
There was a problem hiding this comment.
Thanks for the explanations. LGTM
|
as nobody complains and i think having some (2.946) more passing tests will help as at least a bit while doing all that major changes on our list |
* updates the version of the test262 project in use to the latest one (3fd4ec27f1798ebecafc73b354a45dcdda9bde29) * adds some missing folders to our setup and adjusts the UNSUPPORTED_FEATURES (cherry picked from commit c242a2e)
3 participants
This
Overall we now run 103.018 tests (instead of 99.554); and we have 2.946 new passing tests.