Fully separate object and scope types.#2331
Draft
aardvark179 wants to merge 11 commits intomozilla:masterfrom
Draft
Fully separate object and scope types.#2331aardvark179 wants to merge 11 commits intomozilla:masterfrom
aardvark179 wants to merge 11 commits intomozilla:masterfrom
Conversation
aardvark179
force-pushed
the
aardvark179-scope-object-full-separation
branch
2 times, most recently
from
ff71ab6 to
c87db19
Compare
Contributor
|
@aardvark179 |
aardvark179
force-pushed
the
aardvark179-scope-object-full-separation
branch
4 times, most recently
from
384f995 to
6087c1e
Compare
aardvark179
force-pushed
the
aardvark179-scope-object-full-separation
branch
5 times, most recently
from
7dedc73 to
a040e65
Compare
aardvark179
force-pushed
the
aardvark179-scope-object-full-separation
branch
from
a040e65 to
6d72b27
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is the final stage of separating objects and scopes and stacks on top of #2330, and resolves #2163.
This PR does the final separation of
VarScopeandScriptablemaking them both subclasses ofPropHolder<T>, and then removes the oldNativeWithclass as it is no longer used.