Draft
Conversation
aardvark179
force-pushed
the
aardvark179-new-target
branch
3 times, most recently
from
3cae341 to
ddbe007
Compare
aardvark179
force-pushed
the
aardvark179-new-target
branch
4 times, most recently
from
7af8644 to
b13bdc1
Compare
aardvark179
force-pushed
the
aardvark179-new-target
branch
7 times, most recently
from
5843f08 to
6876342
Compare
aardvark179
force-pushed
the
aardvark179-new-target
branch
3 times, most recently
from
e4395a0 to
a38d362
Compare
aardvark179
force-pushed
the
aardvark179-new-target
branch
from
a38d362 to
a337002
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR stacks on top of #2334 and adds the following commits:
Implement runtime semantics of new target.
Expose new.target in the language.
Enable new.target in 262 tests.
Now that almost every built in function is converted over to the new
JSDescriptorandJSCodemodel we can passnew.targeteasily to both built in and JS functions, so it seems like the right moment to implement that and expose this at the JS level.