Skip to content

Make OSGi integration test closer to a real-world environment#2370

Merged
gbrail merged 1 commit into
mozilla:masterfrom
pavelhoral:fix-osgi-test
May 2, 2026
Merged

Make OSGi integration test closer to a real-world environment#2370
gbrail merged 1 commit into
mozilla:masterfrom
pavelhoral:fix-osgi-test

Conversation

@pavelhoral
Copy link
Copy Markdown
Contributor

This is an update to how I implemented OSGi tests as I have discovered the actual test differs from what is the real-world usage.

What has been changed:

  • tests don't have rhino modules on classpath (which could affect what ServiceLoader see)
  • OSGi tests do not "hack" Thread Context Class Loader, but they instead use SPI Fly for proper integration testing

@pavelhoral pavelhoral marked this pull request as ready for review April 20, 2026 06:28
@gbrail
Copy link
Copy Markdown
Collaborator

gbrail commented May 2, 2026

It's been a while since I touched Osgi but it makes sense to me. Thanks!

@gbrail gbrail merged commit 2836dde into mozilla:master May 2, 2026
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants