Refactor compilation API for full type-safety#2388
Merged
Conversation
0xe
approved these changes
May 7, 2026
andreabergia
force-pushed
the
scratch/ab/source-maps-2
branch
from
decabea to
e29b700
Compare
This was referenced May 7, 2026
Gets rid of the unchecked casts in `Context` for function or script compilation by completely splitting the API in two in the `Evaluator` interface. The `<T>` gets propagated and makes the code wholly type-safe, at the cost of a couple interfaces more. Also added a test about the "can't compile => fallback to interpreter" pre-existing feature.
andreabergia
force-pushed
the
scratch/ab/source-maps-2
branch
from
dae4cdf to
97914ec
Compare
Collaborator
|
Looks good to me too, thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implements Duncan's suggestion. Stacked on top of #2386
Gets rid of the unchecked casts in
Contextfor function or script compilation by completely splitting the API in two in theEvaluatorinterface. The<T>gets propagated and makes the code wholly type-safe, at the cost of a couple interfaces more.Also added a test about the "can't compile jvm class => fallback to interpreter" pre-existing feature.