Skip to content
This repository was archived by the owner on Jan 25, 2018. It is now read-only.

Return a list of failed apps (bug 895199)#120

Merged
davidbgk merged 1 commit intomozilla:masterfrom
davidbgk:895199-failed-apps
Aug 8, 2013
Merged

Return a list of failed apps (bug 895199)#120
davidbgk merged 1 commit intomozilla:masterfrom
davidbgk:895199-failed-apps

Conversation

@davidbgk
Copy link
Contributor

To be discussed:

  • the end-goal of that API, who will consume it and how?
  • the potential split of transaction failures vs. statuses failures
  • the structure/content of information returned
  • the use of a REST framework vs. a services' function-based view

@wraithan
Copy link
Contributor

r+ thanks for breaking out the tests and limiting the try/except scope!

@wraithan
Copy link
Contributor

wraithan commented Aug 7, 2013

  1. Marketplace consumes the api however we want it to.
  2. When in doubt, make them two different statuses and we can later merge them.
  3. Up to you, current format looks fine.
  4. DRF lets us use function based views as part of a rest framework, you did that, I like it.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

transaction_* is tedious, would {'product_id', 'transaction': {'id': '..'}, 'status': {'id': '..'}} be nicer?

@wraithan
Copy link
Contributor

wraithan commented Aug 8, 2013

r+

davidbgk added a commit that referenced this pull request Aug 8, 2013
Return a list of failed apps (bug 895199)
@davidbgk davidbgk merged commit d77e2c6 into mozilla:master Aug 8, 2013
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants