Implement a start transaction API endpoint in Solitude (bug 987836)#212
Conversation
jaredlockhart
commented
Apr 10, 2014
jaredlockhart
commented
- Create a Boku Transaction Form that wraps the start transaction endpoint in the Boku client
- Create an API View which wraps the form
- Add form and view tests as necessary
There was a problem hiding this comment.
are these the only countries we can sell in or something else?
There was a problem hiding this comment.
These are the countries we support. Any countries not in this list will fail validation and be unable to start a transaction.
There was a problem hiding this comment.
then we don't need either of those countries, but we do need Phantom
There was a problem hiding this comment.
in other words, this should probably be choices=ACTIVE_COUNTRY_CHOICES with only Phantom in it
|
looks good to me, good work |
lib/boku/client.py
Outdated
There was a problem hiding this comment.
use spaces between the slash for pyflakes
There was a problem hiding this comment.
like num / (num ** decimal_places)
There was a problem hiding this comment.
Weird, that was already passing pep8, pyflakes, and flake8.
|
This needs a patch that adds API documentation: https://solitude.readthedocs.org/en/latest/topics/boku.html If that slows you down, file a bug to add documentation later. |
There was a problem hiding this comment.
I know it was from a previous patch but I'd say remove button_markup from the return output of start_transaction(). I can't think of any situation where we would need button markup.
|
r+wc, let's land this asap to test on dev! |
- Create a Boku Transaction Form that wraps the start transaction endpoint in the Boku client - Create an API View which wraps the form - Add form and view tests as necessary
|
r+ |
Implement a start transaction API endpoint in Solitude (bug 987836)
3 participants
