Skip to content
This repository was archived by the owner on May 28, 2019. It is now read-only.

Remove DNT for GA in payments (bug 1112061) - #178

Merged
muffinresearch merged 2 commits into
mozilla:masterfrom
muffinresearch:remove-dnt
Dec 16, 2014
Merged

Remove DNT for GA in payments (bug 1112061)#178
muffinresearch merged 2 commits into
mozilla:masterfrom
muffinresearch:remove-dnt

Conversation

@muffinresearch

Copy link
Copy Markdown
Contributor

No description provided.

@muffinresearch muffinresearch changed the title Remove DNT for GA in payments Remove DNT for GA in payments (bug 1112061) Dec 16, 2014
@mstriemer

Copy link
Copy Markdown
Contributor

Just to be clear we're not tracking anything specific to a user right? This is just enabling the anonymous GA tracking for page views, browser stats, etc?

@mstriemer

Copy link
Copy Markdown
Contributor

I'm not sure how clientID is used but maybe we shouldn't set one if the user has DNT on?

@muffinresearch

Copy link
Copy Markdown
Contributor Author

The clientID stuff is still in fireplace's tracking.js which is where this code came from. https://github.com/mozilla/fireplace/blob/master/src/media/js/tracking.js#L12

@muffinresearch

Copy link
Copy Markdown
Contributor Author

Just to be clear we're not tracking anything specific to a user right? This is just enabling the anonymous GA tracking for page views, browser stats, etc?

Afaik - see the original bug for the discussion around this: https://bugzilla.mozilla.org/show_bug.cgi?id=1032941

@mstriemer

Copy link
Copy Markdown
Contributor

Cool, r+

muffinresearch added a commit that referenced this pull request Dec 16, 2014
Remove DNT for GA in payments (bug 1112061)
@muffinresearch
muffinresearch merged commit 2a7cca8 into mozilla:master Dec 16, 2014
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants