Skip to content

Add a command to publish a crate on crates.io#164

Merged
marco-c merged 5 commits intomozilla:masterfrom
Luni-4:cargo-publish
Jun 17, 2020
Merged

Add a command to publish a crate on crates.io#164
marco-c merged 5 commits intomozilla:masterfrom
Luni-4:cargo-publish

Conversation

@Luni-4
Copy link
Copy Markdown
Collaborator

@Luni-4 Luni-4 commented Jun 16, 2020

This PR fixes #160

Thanks in advance for your review! :)

@Luni-4 Luni-4 requested a review from marco-c June 16, 2020 10:00
Comment thread taskboot/cargo.py Outdated
@marco-c
Copy link
Copy Markdown
Collaborator

marco-c commented Jun 16, 2020

There are some linting issues.

We'll need to add the command to the docs on the wiki (https://github.com/mozilla/task-boot/wiki).

@La0
Copy link
Copy Markdown
Contributor

La0 commented Jun 16, 2020

AFAIK Taskboot does not have cargo available in its path. Do you plan to add it in the Dockerfile ?

$ docker run --rm -it mozilla/taskboot cargo
docker: Error response from daemon: OCI runtime create failed: container_linux.go:349: starting container process caused "exec: \"cargo\": executable file not found in $PATH": unknown.

@Luni-4
Copy link
Copy Markdown
Collaborator Author

Luni-4 commented Jun 16, 2020

AFAIK Taskboot does not have cargo available in its path. Do you plan to add it in the Dockerfile ?

$ docker run --rm -it mozilla/taskboot cargo
docker: Error response from daemon: OCI runtime create failed: container_linux.go:349: starting container process caused "exec: \"cargo\": executable file not found in $PATH": unknown.

Sure, thanks for catching it! :)

@Luni-4 Luni-4 requested a review from marco-c June 16, 2020 14:38
Comment thread taskboot/cargo.py Outdated
Comment thread taskboot/cargo.py
Comment thread taskboot/cargo.py Outdated
Comment thread taskboot/cargo.py Outdated
@Luni-4 Luni-4 requested a review from marco-c June 16, 2020 14:50
Comment thread taskboot/cargo.py Outdated
@Luni-4 Luni-4 requested a review from marco-c June 17, 2020 08:25
Copy link
Copy Markdown
Collaborator

@marco-c marco-c left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@marco-c marco-c merged commit 2472616 into mozilla:master Jun 17, 2020
@Luni-4 Luni-4 deleted the cargo-publish branch June 17, 2020 09:23
@Luni-4
Copy link
Copy Markdown
Collaborator Author

Luni-4 commented Jun 17, 2020

We'll need to add the command to the docs on the wiki (https://github.com/mozilla/task-boot/wiki).

Updated the documentation

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Create a new command to publish a given crate on crates.io

3 participants