This repository was archived by the owner on Feb 14, 2025. It is now read-only.
Fix experiment metadata output#273
Merged
Merged
Conversation
fbertsch
approved these changes
Jul 24, 2017
fbertsch
left a comment
fbertsch
left a comment
Contributor
There was a problem hiding this comment.
Ah dang, I should have caught this.
Codecov Report
@@ Coverage Diff @@
## master #273 +/- ##
=======================================
Coverage 66.12% 66.12%
=======================================
Files 37 37
Lines 3371 3371
Branches 80 80
=======================================
Hits 2229 2229
Misses 1142 1142
Continue to review full report at Codecov.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The metadata output had a bug where each experiment was outputting metadata every experiment, not just its own, because I passed in the unfiltered dataset. Whoops.
cc @robhudson