This repository was archived by the owner on Feb 14, 2025. It is now read-only.
Clean History: Add a "Main Summary" data set per Bug 1260847 - #48
Merged
Conversation
This was referenced Apr 1, 2016
| lazy val weaveDesktop = Utils.enumHistogramToCount(histograms \ "WEAVE_DEVICE_COUNT_DESKTOP") | ||
| lazy val weaveMobile = Utils.enumHistogramToCount(histograms \ "WEAVE_DEVICE_COUNT_MOBILE") | ||
|
|
||
| // TODO: confirm that it is safe to consider a wonky histogram as zero. |
Contributor
Author
There was a problem hiding this comment.
Is there a better alternative to this behaviour? It was kind of a toss-up here between zero, null, and some "special" flag-value like -1. I'm still unsure what's best, though zero is clearly the most convenient for analysis.
Contributor
There was a problem hiding this comment.
Imho null would be preferable to signal that no (meaningful) data is available as 0 has a different meaning.
Contributor
Author
There was a problem hiding this comment.
Ok, I'll change to use null for missing/bad sums
Contributor
|
Looks good, thanks. Could you please rebase your commits and add a clear commit message? |
Addresses the following: * Bug 1260847 - Create a general "summary" derived dataset for main pings * Bug 1261829 - Add LOOP_ACTIVITY_COUNTER histogram to main summary dataset * Bug 1262478 - Add DEVTOOLS_TOOLBOX_OPENED_COUNT to main summary dataset
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is intended to be the go-to data set for analysis of 100% of main pings. Same as #47 but with a cleaned up commit history.