Bug 1594822 - Remove Autoclassify and Crossreference code#6897
Merged
Conversation
camd
force-pushed
the
remove-autoclassify
branch
2 times, most recently
from
229c5cd to
a559aee
Compare
Codecov Report
@@ Coverage Diff @@
## master #6897 +/- ##
==========================================
- Coverage 88.17% 87.81% -0.37%
==========================================
Files 285 276 -9
Lines 13398 12859 -539
==========================================
- Hits 11814 11292 -522
+ Misses 1584 1567 -17
Continue to review full report at Codecov.
|
| autoclassify_status = models.IntegerField(choices=AUTOCLASSIFY_STATUSES, default=PENDING) | ||
|
|
||
| # TODO: Remove coalesced_to_guid next time the jobs table is modified (bug 1402992) | ||
| coalesced_to_guid = models.CharField(max_length=50, null=True, default=None) |
Contributor
There was a problem hiding this comment.
Is it worth removing project_specific_id and coalesced_to_guid while you're here?
Collaborator
Author
There was a problem hiding this comment.
Great point, yeah. I'll do that.
camd
force-pushed
the
remove-autoclassify
branch
from
a512e59 to
cebe27d
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This removes nearly all the code for Autoclassify and Crossreferencing. There are small parts left behind because they're used by Push Health, etc.
This compliments Aki's PR for #6891, which removed the lines that call into this code. So this is basically just a cleanup after his.