Skip to content

Bug 1594822 - Remove Autoclassify and Crossreference without migration#6915

Merged
camd merged 3 commits into
masterfrom
remove-autoclassify-without-migration
Dec 15, 2020
Merged

Bug 1594822 - Remove Autoclassify and Crossreference without migration#6915
camd merged 3 commits into
masterfrom
remove-autoclassify-without-migration

Conversation

@camd
Copy link
Copy Markdown
Collaborator

@camd camd commented Dec 15, 2020

This is the same code as #6897 but doesn't do the migration. The migration keeps timing out. I will do the migration in a separate step, probably manually via mysql> cli and then mark the migration as completed in the django table by hand.

@camd camd temporarily deployed to treeherder-prototype December 15, 2020 18:13 Inactive
@camd camd force-pushed the remove-autoclassify-without-migration branch from 1ef51fb to 878e8dd Compare December 15, 2020 18:52
@codecov-io
Copy link
Copy Markdown

codecov-io commented Dec 15, 2020

Codecov Report

Merging #6915 (878e8dd) into master (1a7a677) will decrease coverage by 0.34%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #6915      +/-   ##
==========================================
- Coverage   88.22%   87.87%   -0.35%     
==========================================
  Files         289      279      -10     
  Lines       13666    13132     -534     
==========================================
- Hits        12057    11540     -517     
+ Misses       1609     1592      -17     
Impacted Files Coverage Δ
tests/autoclassify/utils.py 82.69% <ø> (-11.65%) ⬇️
tests/conftest.py 96.02% <ø> (-0.06%) ⬇️
tests/model/test_classified_failure.py 100.00% <ø> (ø)
treeherder/config/settings.py 88.88% <ø> (ø)
treeherder/model/error_summary.py 94.11% <ø> (-1.18%) ⬇️
treeherder/model/models.py 80.52% <ø> (-6.37%) ⬇️
treeherder/webapp/api/jobs.py 82.22% <ø> (-0.20%) ⬇️
... and 1 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1a7a677...878e8dd. Read the comment docs.

@camd camd merged commit ed41015 into master Dec 15, 2020
@camd camd deleted the remove-autoclassify-without-migration branch December 15, 2020 19:08
@codecov-commenter
Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 87.87%. Comparing base (1a7a677) to head (878e8dd).
⚠️ Report is 1699 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #6915      +/-   ##
==========================================
- Coverage   88.22%   87.87%   -0.35%     
==========================================
  Files         289      279      -10     
  Lines       13666    13132     -534     
==========================================
- Hits        12057    11540     -517     
+ Misses       1609     1592      -17     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants