Skip to content
This repository was archived by the owner on Jul 16, 2018. It is now read-only.

Bug 896664 Split #534

Closed
shaj02 wants to merge 1 commit into from
Closed

Bug 896664 Split #534

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion public/css/ui.less
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -470,7 +470,8 @@ figure {
position: absolute;
bottom: 10px;
left: 10px;

margin-left: 5px;

&:hover {
text-decoration: none;
background-color: lighten(@blue, 10%);
Expand Down
10 changes: 5 additions & 5 deletions views/event-guides.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@

<div class="ui-row">
<div class="guide-columns ui-bg-column">
<img src="/img/img-Guides-Kitchen-Party.jpg" alt="{{ gettext("Kitchen Party") }}" />
<img style="margin-left: 5.5px" src="/img/img-Guides-Kitchen-Party.jpg" alt="{{ gettext("Kitchen Party") }}" />
Copy link
Copy Markdown
Contributor

@Pomax Pomax Jan 13, 2014

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

inline style attributes are not allowed in our code. Please make this a class="..." and then have a specific-enough rule in the stylesheet for controlling this margin.

<img src="/img/icon-Guides-Kitchen-Party.png" class="logo" alt="{{ gettext("Kitchen Party Logo") }}" />
<h2>{{ gettext("Kitchen Party") }}</h2>
<p>{{ gettext("A Kitchen Party is a fun way to") }}
Expand All @@ -35,20 +35,20 @@ <h3>{{ gettext("Start Planning") }}</h3>
<li>{{ gettext("Home, cafe, library") }}</li>
</ul>

<a class="ui-blue-btn" href="https://webmaker.makes.org/thimble/how-to-host-a-kitchen-party">{{ gettext("Kitchen Party Planning Guide") }}<i class="icon-angle-right"></i></a></p>
<a class="ui-blue-btn" href="https://webmaker.makes.org/thimble/how-to-host-a-kitchen-party">{{ gettext("Kitchen Party Planning Guide") }}<span class="icon-angle-right" style="font-size: 1.4em; margin-right: 0.1em; margin-left: 4px;"></span></a></p></p>
</div>
<div class="guide-columns ui-bg-column">
<img src="/img/img-Guides-Hack-Jam.jpg" alt="{{ gettext("Hack Jam") }}" />
<img src="/img/icon-Guides-Hack-Jam.png" class="logo" alt="{{ gettext("Hack Jam Logo") }}" />
<img style="marign-left: 5.5px;" src="/img/icon-Guides-Hack-Jam.png" class="logo" alt="{{ gettext("Hack Jam Logo") }}" />
Copy link
Copy Markdown
Contributor

@Pomax Pomax Jan 13, 2014

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

same issue; no inline styles.

<h2>{{ gettext("Hack Jam") }}</h2>
<p>{{ gettext("A Hack Jam is a great way to") }}
<ul>
<li>{{ gettext("Team up to explore") }}</li>
<li>{{ gettext("Collaboratively build or improve") }}</li>
<li>{{ gettext("Learn and teach new hacking skills") }}</li>
</ul>
<h3>{{ gettext("Start Planning") }}</h3>
<ul>
<h3 style="margin-top: 36px">{{ gettext("Start Planning") }}</h3>
Copy link
Copy Markdown
Contributor

@Pomax Pomax Jan 13, 2014

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

same issue; no inline styles

<ul style="margin-top: 16px">
<li>{{ gettext("10 - 50 participants") }}</li>
<li>{{ gettext("4 hours, 2 weeks") }}</li>
<li>{{ gettext("School, library") }}</li>
Expand Down