This repository was archived by the owner on Mar 15, 2018. It is now read-only.
Handle empty permissions for packaged apps (bug 1039067)#2326
Merged
mstriemer merged 1 commit intoJul 17, 2014
Conversation
Contributor
There was a problem hiding this comment.
I think set creation is going to be a lot slower than using any. any can also bail out early if it can.
I also don't see the difference between old L165-166 and L165.
Contributor
Author
There was a problem hiding this comment.
When the app doesn't define a permissions key in its manifest the app-validator sets "permissions": false in its validation results. So I moved the default outside of the get. I meant to add a comment. I'll do that.
I'll switch back to the any. I had just noticed that PRERELEASE_PERMISSIONS was already a set so I did intersection.
mstriemer
added a commit
that referenced
this pull request
Jul 17, 2014
…39067 Handle empty permissions for packaged apps (bug 1039067)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
https://bugzilla.mozilla.org/show_bug.cgi?id=1039067
Handle the case where there aren't any permissions in the manifest which the app-validator helpfully represents as
Falseinstead of[].