This repository was archived by the owner on Mar 15, 2018. It is now read-only.
fix alignment of rating error message (bug 842294) #606
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
Could do - though it's more explicit with the error message. |
Contributor
|
have you seen this? that's what UX wants to do. if you can do that instead to fix this, I'm a happy camper ⛺ |
Member
|
If that patch fixes the bug, let's close it. We'll get to the next bug when we can but let's not move the goal posts on this bug if we already have a patch. |
Contributor
|
the issue was that this bug was filed before other bugs were filed. in theory, we shouldn't have 4 bugs for this same problem. |
Contributor
|
@muffinresearch merge it in, thanks |
muffinresearch
added a commit
that referenced
this pull request
Feb 21, 2013
…g-842294 Fix alignment of rating error message (bug 842294)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix for rating error message being out of alignment with the char count.