fix(ci): add .yamllint.yml to fix failing lint-yaml job - #447
Merged
Conversation
Copilot
AI
changed the title
[WIP] Fix failing GitHub Actions job lint-yaml
fix(ci): add .yamllint.yml to fix failing lint-yaml job
Jul 20, 2026
mpaulosky
approved these changes
Jul 20, 2026
Contributor
🏗️ PR Added to Squad Triage QueueThis PR has been labeled with Next steps:
|
Contributor
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #447 +/- ##
=======================================
Coverage 76.73% 76.73%
=======================================
Files 71 71
Lines 1775 1775
Branches 214 214
=======================================
Hits 1362 1362
Misses 336 336
Partials 77 77 🚀 New features to boost your workflow:
|
mpaulosky
marked this pull request as ready for review
July 20, 2026 13:48
There was a problem hiding this comment.
Pull request overview
This PR fixes the failing squad-standard-lint-yaml.yml job by adding a repo-root .yamllint.yml so yamllint (invoked without -c) uses consistent, project-appropriate rules instead of strict built-in defaults (notably the 80-character line-length rule).
Changes:
- Added a root
.yamllint.ymlthat yamllint auto-discovers when no-cflag is provided. - Relaxed
line-lengthtomax: 200(matching the existing inline config used by.github/workflows/lint-yaml.yml). - Tuned rules for GitHub Actions YAML patterns (
truthyallowingon, disabledocument-start) and ignored.squad/YAML files.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
squad-standard-lint-yaml.ymlrunsyamllint -s $fileswith no-cflag, so it falls back to yamllint's built-in defaults (80-char line limit). Several workflow files have lines exceeding that limit (dotnet CLI commands, shell scripts), causing[line-length]errors and a non-zero exit.Changes
.yamllint.ymlat repo root — yamllint auto-discovers this when run without-cline-length: max: 200— matches the inline config already used inlint-yaml.ymldocument-start: disable— GitHub Actions workflows omit---truthy: allowed-values: ['true', 'false', 'on']—on:is standard in GHAcomments: min-spaces-from-content: 1— pre-existing files use single-space before inline commentsbracketsspacing — consistent withlint-yaml.ymlignore: .squad/— excludes squad orchestration filesType of Change
Domain Affected
Self-Review Checklist
Code Quality
dotnet build MyBlog.slnx --configuration Release— 0 errors, 0 warningsdotnet test MyBlog.slnx --configuration Release --no-build— all passArchitecture
Command/Query/Handler/Validatornaming conventionssealedWeborPersistence.*projectsResult<T>/ResultErrorCodeused for expected failures (no exception-driven control flow)Domain.DTOs; Models are inDomain.ModelsTests
[Collection("XxxIntegration")])IssueDto.Empty/CommentDto.Emptyinstances directlySecurity (check if security-relevant)
RequireAuthorization/ policy appliedMarkupStringused with user-supplied contentMerge Readiness
main(no merge conflicts)Screenshots / Evidence
yamllint -s $(git ls-files '*.yml' '*.yaml' | tr '\n' ' ')exits 0 locally with the new config in place. Previously failed with exit code 1 on[line-length]errors insquad-insider-release.yml,squad-milestone-release.yml,squad-promote.yml,squad-release.yml, andsquad-standard-lint-markdown.yml.Notes for Reviewers
The new
.yamllint.ymlis now the single source of truth for YAML lint rules across bothlint-yaml.yml(usesibiqlik/action-yamllintwith inlineconfig_data— unaffected) andsquad-standard-lint-yaml.yml(now inherits from the file). The two configs were previously divergent; this brings them into alignment.