Fix "Undefined array key" warning in MultiCell with an empty string - #2197
Open
eyupcanakman wants to merge 1 commit into
Open
Fix "Undefined array key" warning in MultiCell with an empty string#2197eyupcanakman wants to merge 1 commit into
eyupcanakman wants to merge 1 commit into
Conversation
sliceOTLdata() read the group and GPOSinfo keys before they were set when MultiCell runs with no OpenType layout data, so PHP 8 raised "Undefined array key". Set both keys to their empty defaults at the start of the function, the same way char_data is already guarded below. Refs mpdf#2158
jakejackson1
added a commit
to GravityPDF/mpdf
that referenced
this pull request
Sep 7, 2026
Tolerate empty OTL data when slicing a line of text (mirrors mpdf#2197)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
MultiCell()with an empty string warns on PHP 8.Otl::sliceOTLdata()reads thegroupandGPOSinfokeys before they are set when there is no OpenType layout data, which raises "Undefined array key". The fix sets both keys to their empty defaults at the top of the function, the same waychar_datais already guarded just below.The other error in #2158 (long text with
align: 'J') is a different path inGetJspacing(), tracked in #2184. Out of scope here.