Drag & drop improvements (URLs, files when paused ...)

[xnoreq]

Hello,

right now it is possible to drag files from Explorer and drop them on mpv.

Improvement a): mpv will only start playing the dropped file if it was still playing. When paused before dropping, the file dropped will be ignored.

Improvement b): Dropping URLs doesn't work at all. mpv doesn't accept URLs to be dropped.

When paused before dropping, the file dropped will be ignored.

What for?

Dropping URLs doesn't work at all. mpv doesn't accept URLs to be dropped.

This should work... no idea why it wouldn't.

[xnoreq]

I'm on Windows using the x86-64 build, version 0.3.1.

a) Sorry, I should have been more clear. That's the current situation.
Dropping files while playing works fine, but if I pause before dropping, mpv ignores the dropped file. I get the correct drag & drop icon but nothing happens after releasing the mouse.
=> What should happen is that the dropped file gets played regardless of playback state.

b) When dragging a link from Firefox onto the mpv window I get the "stop" cursor, so mpv doesn't even seem to accept that type of object.

a) seems to work on X11. Is it possibly a windows problem? Although I can't imagine how that would happen.

b) not sure, maybe URLs use a different format from normal files.

[xnoreq]

a) You can drop a file on a paused mpv and mpv will start playing the dropped file? That definitely doesn't work here. Could very well be Windows specific. Any way to debug the drop handler?

b) They most certainly do.
Using ClipSpy you can see that dropping file(s) from Windows Explorer results in a Shell IDList Array and there's CF_HDROP with the filenames (see http://msdn.microsoft.com/en-us/library/windows/desktop/bb776902%28v=vs.85%29.aspx)

Dropping a link from Firefox results in a text/uri-list. There's also text/x-moz-url-data and -desc which is Mozilla specific and other stuff, but just handling text/uri-list should be enough.

If you want to go fancy you could even handle text/html and parse that for URLs so that a user could select multiple links and drag&drop them into mpv. Mpv could then add all URLs into a fresh playlist or append them...
Btw, this doesn't work with files either: selecting multiple files and dropping them into mpv just plays the one under the cursor, the others are ignored. It seems like mpv is only handling FileNameW (only the filename of the file under the mouse cursor) instead of CF_HDROP which contains all selected files.

Any way to debug the drop handler?

Don't know. The code is in video/out/w32_common.c. Look for WM_DROPFILES.

Dropping a link from Firefox results in a text/uri-list.

That's convenient. We already have code for that, because it's used on Linux. Is this Firefox/Mozilla specific on Windows?

If you want to go fancy you could even handle text/html and parse that for URLs so that a user could select multiple links and drag&drop them into mpv.

Better not...

selecting multiple files and dropping them into mpv just plays the one under the cursor, the others are ignored.

It should start playing the first file, and when that is done, play the next file. That's what should be happening.

[xnoreq]

Okay, I will take a look at the code.
Indeed, parsing html seems too messy but is there another way to append URLs? Creating a playlist file doesn't seem very conveniant.

It should start playing the first file, and when that is done, play the next file. That's what should be happening.

Okay, so that's another Windows-specific bug it seems.

One thing to note is that the code should use the functions in input/event.h, instead of creating the loadfile commands manually.

[xnoreq]

Dropping multiple files apparently does work. It's just that the OSD has grayed out the previous/next buttons, but < and > key work.

DROPFILES seems to be really, really old Windows crap that can only handle files. URLs and other stuff needs OLE (COM). C++ classes? :D Maybe there's a way to work around with C-style COM interfaces ...

Heh, I knew the code looked too simple...

[xnoreq]

See my work at https://github.com/xnoreq/mpv/tree/w32-dnd (only edited video/out/w32_common.c)

It's certainly not the most beautiful piece of code, but it does seem to work and even fixed the pause-ignores-drop problem.

[mia-0]

Merged with some minor changes (formatting and use of talloc contexts), worked fine on Win7 64-bit.

Thanks for that!