Fullscreen in Xmonad stopped working (needed fstype=fullscreen)

[kuerzn]

I tried the new x11-netwm=no option, which also did not help.

Known problem. Xmonad doesn't advertise the _NET_WM_STATE_FULLSCREEN hint in the _NET_SUPPORTED property. In fact, it seems they refuse to add support for it. As consequence, mpv falls back to the non-NetWM fullscreen hack, which doesn't work with xmonad.

[kuerzn]

Would it be possible to have the fstype option back? This change deliberately breaks mpv for every XMonad user. I understand that it is stupid of XMonad refuses to help with this! But not implementing something is not the same as removing something that already worked, isn't it?

Well, this was done while removing hacks for 90ies-era window managers, and making it work more nicely with modern window managers. I had no idea that it would affect xmonad.

[kuerzn]

And now? Any suggestions?

Are there any signs that xmonad is going to fix this?

[liskin]

Would fullscreenEventHook from XMonad.Hooks.EwmhDesktops help, perhaps? Support for _NET_WM_STATE_FULLSCREEN isn't advertised (although I've been running with a patched version that advertises it for years without problems), but --x11-netwm=yes should be enough to force it.

[haasn]

In case it helps anybody, I use this in my manageHook:

fmap ("mpv" `isPrefixOf`) title --> doFullFloat

What we require is exactly that _NET_WM_STATE_FULLSCREEN is advertised. --x11-netwm=yes is the default; you can use it only to switch of netwm fullscreen. (Maybe this could be changed.)

[johannesgerer]

Yes, with this patch it works:
http://markmail.org/message/ldoawspla5eqap7h#query:+page:1+mid:ldoawspla5eqap7h+state:results

Does anybody know, why this cannot be merged into the main version? Or at least an option to advertise _NET_WM_STATE_FULLSCREEN?

@johannesgerer: that link doesn't work.

[johannesgerer]

I changed it, should be working now

[mtf90]

Maybe a little OT, but as the titles states: In previous versions it worked with

--fstype='fullscreen'

However since 0.4 I get the message

The --fstype option was renamed or replaced: --x11-fstype

When I use

--x11-fstype='fullscreen'

I get

Error parsing option x11-fstype (option not found)

So fixing this might actually fix this bug, too?

So fixing this might actually fix this bug, too?

No. --x11-fstype doesn't cover all of the functionality --fstype provided. However, the functionality was removed on purpose. It was mainly for 90ies era window managers, and I was assuming that no modern window manager needs this anymore. For the rest, read this issue.

[johannesgerer]

I think what @mtf90 is trying to say is: The message proposes to use x11-fstype, which does not exist!