Skip to content

Comments

Revert "input.conf: bind MBTN_MID to align-to-cursor"#15961

Merged
kasper93 merged 1 commit intompv-player:masterfrom
kasper93:input_pos
Mar 23, 2025
Merged

Revert "input.conf: bind MBTN_MID to align-to-cursor"#15961
kasper93 merged 1 commit intompv-player:masterfrom
kasper93:input_pos

Conversation

@kasper93
Copy link
Member

For symmetry with drag-to-pan. Use MBTN_MID to reset the video position.

@github-actions
Copy link

github-actions bot commented Feb 25, 2025

Download the artifacts for this pull request:

Windows
macOS

@kasper93 kasper93 modified the milestone: Release v0.40.0 Mar 1, 2025
@kasper93 kasper93 marked this pull request as draft March 4, 2025 22:10
@kasper93
Copy link
Member Author

Whatever.

@kasper93 kasper93 closed this Mar 10, 2025
@na-na-hi
Copy link
Contributor

I would like to see this merged. Panning video just because I clicked on MBTN_MID, not even dragging, with no way to reset with only mouse (it did before but was then broken on purpose because toggle_align_to_cursor feature and copying whatever sxiv does is apparently much more important than sane behavior), is jarring and useless for the vast majority of cases of viewing videos.

And it's not even copying it right in this case. sxiv won't pan the image off-center, so it won't activate when the image isn't already zoomed in, unlike current mpv where it makes video off-center even when not zoomed in.

@kasper93 kasper93 reopened this Mar 13, 2025
@kasper93
Copy link
Member Author

I also don't like that MBTN_MID moves the image, especially if it is in nominal state. Image viewers generally allow pan only if image is zoomed in and doesn't fit the view port. This would be acceptable solution for me.

copying whatever sxiv does is apparently much more important than sane behavior

Not sure if we should copy what image viewers do anyway...

@kasper93 kasper93 changed the title input.conf: move to align-to-cursor to Ctrl+MBTN_RIGHT input.conf: remove align-to-cursor default binding Mar 23, 2025
@kasper93 kasper93 marked this pull request as ready for review March 23, 2025 21:11
It can be too easy to change the video position without a single way to
undo the change. Also, this is mostly useful for images. Binding can be
brought back in a better way with an image profile or another method
that is more resistant to accidental clicks.

This reverts commit e98d3b6.
@kasper93 kasper93 changed the title input.conf: remove align-to-cursor default binding Revert "input.conf: bind MBTN_MID to align-to-cursor" Mar 23, 2025
@kasper93 kasper93 added this to the Release v0.40.0 milestone Mar 23, 2025
@kasper93 kasper93 merged commit 8e4493b into mpv-player:master Mar 23, 2025
26 checks passed
@kasper93 kasper93 deleted the input_pos branch March 23, 2025 21:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants