playloop: only notify MP_EVENT_INPUT_PROCESSED when needed#16042
Merged
kasper93 merged 2 commits intompv-player:masterfrom Mar 26, 2025
Merged
playloop: only notify MP_EVENT_INPUT_PROCESSED when needed#16042kasper93 merged 2 commits intompv-player:masterfrom
kasper93 merged 2 commits intompv-player:masterfrom
Conversation
This makes it possible to distinguish these dummy commands for position update notification from other commands.
MP_EVENT_INPUT_PROCESSED is used to notify mouse and touch position updates, but it is currently notified for all input commands even when they have nothing to do with mouse position. This results in unnecessary acquisition and comparision of mouse and touch positions for all commands. Optimize this by checking whether the command is marked as requiring the event notification, and only notify if that is true.
na-na-hi
force-pushed
the
input-processed
branch
from
15791ae to
428bcb9
Compare
|
Download the artifacts for this pull request: |
kasper93
approved these changes
Mar 26, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
MP_EVENT_INPUT_PROCESSED is used to notify mouse and touch position updates, but it is currently notified for all input commands even when they have nothing to do with mouse position. This results in unnecessary acquisition and comparision of mouse and touch positions for all commands.
Optimize this by checking whether the command is marked as requiring the event notification, and only notify if that is true.