Skip to content

Conversation

@Dudemanguy
Copy link
Member

In retrospect, this isn't so great because no neccesarily everyone would want the mouse to show with the menu and said menu can be navigated with the keyboard anyway.

This reverts commit a8f5beb.

In retrospect, this isn't so great because not neccesarily everyone
would want the mouse to show with the menu and said menu can be
navigated with the keyboard anyway.

This reverts commit a8f5beb.
@github-actions
Copy link

Download the artifacts for this pull request:

Windows
macOS

@hooke007
Copy link
Contributor

The true reason should be that a script would never respect user's option...

@dyphire
Copy link
Contributor

dyphire commented Mar 15, 2025

I think there could be an option to control this behavior. This would be useful in certain scenarios: if the cursor is automatically hidden the user has no way of knowing if the cursor is inside or outside the menu, which affects the action of the mouse after a click. There must be users who think this makes sense and need it.

@Dudemanguy
Copy link
Member Author

We can always hammer out the details later if someone wants but for now let's just get this out of the way for the release.

@Dudemanguy Dudemanguy merged commit 6c42182 into mpv-player:master Mar 15, 2025
26 checks passed
@Dudemanguy Dudemanguy deleted the autohide branch March 15, 2025 05:19
@guidocella
Copy link
Contributor

An option is not needed:

[cursor]
profile-cond=user_data['mpv/console/open']
profile-restore=copy
cursor-autohide=no

@verygoodlee
Copy link
Contributor

An option is not needed:

[cursor]
profile-cond=user_data['mpv/console/open']
profile-restore=copy
cursor-autohide=no

I have used a similar auto profile before

This also affects the input.get(), it doesn't have any mouse keybinding,
expected behavior is to affect only the input.select().

And this will cause excessive spam msg on the console.
image

@guidocella
Copy link
Contributor

We could add user-data/mpv/console/select then. Those applying auto profile messages are annoying in general, I disable them with --msg-level=auto_profiles=warn.

@guidocella
Copy link
Contributor

Another option is to disable cursor-autohide only after the first MOUSE_MOVE. Else separated keyboard and mouse focus styles need to be implemented.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants