ytdl_hook.lua: fix duplicated chapters #16068
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sometimes when opening a YouTube video with chapters, the chapter-list ended up having all the chapters twice, despite the json from yt-dlp only containing them once. That must mean that sometimes add_single_video() runs twice before the chapter_list table gets cleared in the on_preloaded hook. This can be avoided by replacing chapter_list with a new table before adding entries to it.
|
Download the artifacts for this pull request: |
kasper93
approved these changes
Mar 23, 2025
Member
|
Should be safe fix for release. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sometimes when opening a YouTube video with chapters, the chapter-list ended up having all the chapters twice, despite the json from yt-dlp only containing them once. That must mean that sometimes add_single_video() runs twice before the chapter_list table gets cleared in the on_preloaded hook.
This can be avoided by replacing chapter_list with a new table before adding entries to it.
I don't understand why add_single_video() sometimes runs twice before the table gets cleared in on_preloaded, and it happens so rarely that I can't really debug it, but this change should at least prevent the problem with the chapters.