autoload.lua: stop initial file from being added twice

[Ckath]

this happened right after going to the next file. the playlist would be fine when staying on the first file. with logging you can see it 'prepending' the file it was just on.

traced it back to it this behaviour appearing since 5de1f5a
the fix to just throw the current file in the added_entries right away seems to work fine in all scenarios I could think and test

[Ckath]

not only is the script obsolete, I also messed up the commit message

cheers

[llyyr]

Please reopen this, I think it's still useful to fix issues with the script. If it was obsolete it would be removed from the repo.

[Ckath]

sure. after initial discussion in the irc it did seem the --autocreate-playlist=filter works for 'most' cases but some stuff is still not 100% there so I guess there is value in keeping it working if its still in the repo.

[kasper93]

--autocreate-playlist=filter works for 'most' cases but some stuff is still not 100% there

Could you link to the issues with autocreate-playlist that are not 100% there?

[na-na-hi]

Could you link to the issues with autocreate-playlist that are not 100% there?

• It does not react to newly added files in a directory after files are autoloaded, while autoload.lua does.
• Does not support ignore_hidden. It is hardcoded to always ignore hidden files.
• The above also causes buggy behavior that hidden files cannot be played when using autocreate-playlist even when the file is specified in the commandline to open (it just opens another file instead), while autoload.lua plays the file as expected.
• Does not support ignore_patterns.

[kasper93]

Could you link to the issues with autocreate-playlist that are not 100% there?

* It does not react to newly added files in a directory after files are autoloaded, while `autoload.lua` does.

* Does not support `ignore_hidden`. It is hardcoded to always ignore hidden files.

* The above also causes buggy behavior that hidden files cannot be played when using `autocreate-playlist` even when the file is specified in the commandline to open (it just opens another file instead), while `autoload.lua` plays the file as expected.

* Does not support `ignore_patterns`.

Could you create issues for those?

[llyyr]

--autocreate-playlist=filter works for 'most' cases but some stuff is still not 100% there

Could you link to the issues with autocreate-playlist that are not 100% there?

There's also #14675 if you feel like tackling it

[kasper93]

* It does not react to newly added files in a directory after files are autoloaded, while `autoload.lua` does.

This works only by accident and how autoload.lua works. Not by design. For example if you play the last file in folder it wouldn't load anything more, because playlist is recreated on start-file event.

* Does not support `ignore_hidden`. It is hardcoded to always ignore hidden files.

Easy to add, but I haven't seen any requests for this.

* The above also causes buggy behavior that hidden files cannot be played when using `autocreate-playlist` even when the file is specified in the commandline to open (it just opens another file instead), while `autoload.lua` plays the file as expected.

Sounds about right. Might fix, if playing hidden files is critical usecase.

* Does not support `ignore_patterns`.

Ok.

[guidocella]

The problem with patterns is that Windows lacks regex.h.

[kasper93]

The problem with patterns is that Windows lacks regex.h.

We can use C++ or Rust for that.

[avih]

The problem with patterns is that Windows lacks regex.h.

It could use a lua pattern if pattern matching is necessary here, and assuming it's sufficient.

[na-na-hi]

This works only by accident and how autoload.lua works. Not by design. For example if you play the last file in folder it wouldn't load anything more, because playlist is recreated on start-file event.

This behavior is wanted and used by users. See #14555 (comment) and #16125 (allows new file detection on demand).

The problem with patterns is that Windows lacks regex.h.

Can be done if JS is enabled like --sub-filter-jsre.