player/playloop: handle force window in playloop#17212
Merged
kasper93 merged 1 commit intompv-player:masterfrom Jan 7, 2026
Merged
player/playloop: handle force window in playloop#17212kasper93 merged 1 commit intompv-player:masterfrom
kasper93 merged 1 commit intompv-player:masterfrom
Conversation
813c112 moved force window to option callback. This happens before the loading of the file has finished (which is supposed to trigger handle_force_window) so it is too early to handle certain cases, such as loading of album art failed and therefore window will never be created because there is no video track. Adding force window check in playloop to make sure window is always initialized after file loading is complete. Fixes: 813c112
Contributor
|
Can we call it only in Also funny how in this situation mpv plays in the terminal but OSD messages and scripts don't get printed because it presumably tries to output to a window. |
Contributor
Author
It only handles external files which is not enough for correct operation of Lines 1026 to 1028 in f57c5ca Correct solution must make sure |
Member
|
LGTM, thanks! |
kasper93
approved these changes
Jan 7, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
813c112 moved force window to option callback. This happens before the loading of the file has finished (which is supposed to trigger handle_force_window) so it is too early to handle certain cases, such as loading of album art failed and therefore window will never be created because there is no video track.
Adding force window check in playloop to make sure window is always initialized after file loading is complete.
Fixes: 813c112
Fixes: #17209