ci/mac: install ffmpeg-full with homebrew when available#17274
ci/mac: install ffmpeg-full with homebrew when available#17274sfan5 merged 1 commit intompv-player:masterfrom
Conversation
homebrew slimmed down their ffmpeg formula and stripping it off some essential functionality. Homebrew/homebrew-core#261303 use ffmpeg-full instead. this is keg only formula and not automatically symlinked system wide. make sure ffmpeg is not installed in parallel and install ffmpeg-full system wide.
|
removed the conditional installation of ffmpeg(-full) since it's available on all of our runners and we also don't pin the homebrew version to an older one atm. anything pinned in the future will have that version anyway. just making sure ffmpeg and ffmpeg-full are not installed alongside each other. |
wouldn't this be homebrew job to prevent conflicting packages? |
it does technical, since it would lead to an error in this case. ffmpeg-full is a cask formula and isn't installed system wide by default. for our convenience i install it system wide with though if preferred we could add it to our |
|
LGTM, thanks! |
3 participants
homebrew slimmed down their ffmpeg formula and stripping it off some essential functionality.
use ffmpeg-full instead when available. this is a new formula and not available on older homebrew version.additionally, this is keg only formula and not automatically symlinked system wide. make sure ffmpeg is not installed in parallel and install ffmpeg-full system wide.