Skip to content

Conversation

@DavideViolante
Copy link
Contributor

@DavideViolante DavideViolante commented Jul 8, 2025

I removed some rules that was forced to be off, so they are enabled again.
For some rules, I ran npm run lint-fix to automatically fix the problems.
No manual edits where done.

Copy link
Member

@robertsLando robertsLando left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Grazie @DavideViolante :)

@robertsLando robertsLando enabled auto-merge (squash) July 9, 2025 09:41
@robertsLando robertsLando disabled auto-merge July 9, 2025 09:42
@robertsLando robertsLando enabled auto-merge (squash) July 9, 2025 09:42
@robertsLando robertsLando merged commit 8f0f4d4 into mqttjs:main Jul 9, 2025
7 checks passed
@codecov
Copy link

codecov bot commented Jul 9, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 81.68%. Comparing base (1720b64) to head (31bbc02).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2011   +/-   ##
=======================================
  Coverage   81.68%   81.68%           
=======================================
  Files          25       25           
  Lines        1583     1583           
  Branches      368      368           
=======================================
  Hits         1293     1293           
  Misses        199      199           
  Partials       91       91           
Flag Coverage Δ
unittests 81.68% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants