chore: restore some eslint rules and run lint-fix

.eslintrc.js

@@ -22,28 +22,23 @@ module.exports = {
 	rules: {
 		'global-require': 'off',
 		'no-console': process.env.NODE_ENV === 'production' ? 'warn' : 'off',
-		'no-unused-vars': 'off',
+		'no-unused-vars': ['error', { args: 'none' }],
 		'no-underscore-dangle': 'off',
 		'no-param-reassign': 'off',
 		'no-restricted-syntax': 'off',
-		camelcase: 'off',
 		'default-case': 'off',
 		'consistent-return': 'off',
-		'import/order': 'off',
 		'max-classes-per-file': 'off',
 		'no-plusplus': 'off',
-		'guard-for-in': 'off',
 		'no-bitwise': 'off',
 		'class-methods-use-this': 'off',
 		'no-continue': 'off',
-		'prefer-destructuring': 'off',
-		'no-use-before-define': 'off',
 		// Typescript rules
-		'@typescript-eslint/interface-name-prefix': 'off',
-		'@typescript-eslint/explicit-function-return-type': 'off',
-		'@typescript-eslint/explicit-module-boundary-types': 'off',
 		'@typescript-eslint/no-explicit-any': 'off',
-		'@typescript-eslint/no-unused-vars': 'off',
+		'@typescript-eslint/no-unused-vars': [
+			'error',
+			{ args: 'none' }
+		],
 		'@typescript-eslint/naming-convention': 'off',
 		'@typescript-eslint/dot-notation': 'off',
 		'@typescript-eslint/no-use-before-define': 'off',

src/bin/mqtt.ts

@@ -13,7 +13,7 @@ import publish from './pub'
 import subscribe from './sub'
 
 // eslint-disable-next-line @typescript-eslint/no-var-requires
-const version = require('../../package.json').version
+const { version } = require('../../package.json')
 
 const helpMe = help({
 	dir: path.join(__dirname, '../../', 'help'),

src/bin/pub.ts

@@ -8,9 +8,9 @@ import help from 'help-me'
 
 import minimist, { type ParsedArgs } from 'minimist'
 import split2 from 'split2'
-import { connect } from '../mqtt'
 import { type IClientOptions, type IClientPublishOptions } from 'src/lib/client'
 import { pipeline } from 'stream'
+import { connect } from '../mqtt'
 
 const helpMe = help({
 	dir: path.join(__dirname, '../../', 'help'),

src/bin/sub.ts

@@ -4,8 +4,8 @@ import path from 'path'
 import fs from 'fs'
 import minimist from 'minimist'
 import help from 'help-me'
-import { connect } from '../mqtt'
 import { type IClientOptions } from 'src/lib/client'
+import { connect } from '../mqtt'
 
 const helpMe = help({
 	dir: path.join(__dirname, '../../', 'help'),

src/lib/client.ts

@@ -1,7 +1,6 @@
 /**
  * Module dependencies
  */
-import TopicAliasRecv from './topic-alias-recv'
 import mqttPacket, {
 	type IAuthPacket,
 	IConnackPacket,
@@ -15,17 +14,18 @@ import mqttPacket, {
 	type ISubackPacket,
 	type IConnectPacket,
 } from 'mqtt-packet'
-import DefaultMessageIdProvider, {
-	type IMessageIdProvider,
-} from './default-message-id-provider'
 import { type DuplexOptions, Writable } from 'readable-stream'
 import clone from 'rfdc/default'
-import * as validations from './validations'
 import _debug from 'debug'
-import Store, { type IStore } from './store'
-import handlePacket from './handlers'
 import type { ClientOptions } from 'ws'
 import { type ClientRequestArgs } from 'http'
+import * as validations from './validations'
+import Store, { type IStore } from './store'
+import handlePacket from './handlers'
+import DefaultMessageIdProvider, {
+	type IMessageIdProvider,
+} from './default-message-id-provider'
+import TopicAliasRecv from './topic-alias-recv'
 import {
 	type DoneCallback,
 	type ErrorWithReasonCode,
@@ -1157,7 +1157,7 @@ export default class MqttClient extends TypedEventEmitter<MqttClientEventCallbac
 		}
 		opts = { ...defaultOpts, ...opts } as IClientSubscribeOptions
 
-		const properties = opts.properties
+		const { properties } = opts
 
 		const subs: ISubscriptionRequest[] = []
 

src/lib/connect/index.ts

@@ -28,8 +28,9 @@ function parseAuthOptions(opts: IClientOptions) {
 	if (opts.auth) {
 		matches = opts.auth.match(/^(.+):(.+)$/)
 		if (matches) {
-			opts.username = matches[1]
-			opts.password = matches[2]
+			const [, username, password] = matches
+			opts.username = username
+			opts.password = password
 		} else {
 			opts.username = opts.auth
 		}

src/lib/connect/socks.ts

@@ -3,10 +3,10 @@ import { Duplex } from 'stream'
 import { SocksClient, type SocksProxy } from 'socks'
 import * as dns from 'dns'
 import { type SocksProxyType } from 'socks/typings/common/constants'
-import { type IStream } from '../shared'
 import { promisify } from 'util'
 import { type Socket } from 'net'
 import assert from 'assert'
+import { type IStream } from '../shared'
 
 const debug = _debug('mqttjs:socks')
 

src/lib/connect/tcp.ts

@@ -1,7 +1,6 @@
-import { type StreamBuilder } from '../shared'
-
 import net from 'net'
 import _debug from 'debug'
+import { type StreamBuilder } from '../shared'
 import openSocks from './socks'
 
 const debug = _debug('mqttjs:tcp')

src/lib/connect/ws.ts

@@ -1,8 +1,8 @@
-import { type StreamBuilder } from '../shared'
 import { Buffer } from 'buffer'
 import Ws, { type ClientOptions } from 'ws'
 import _debug from 'debug'
 import { type DuplexOptions, Transform } from 'readable-stream'
+import { type StreamBuilder } from '../shared'
 import isBrowser from '../is-browser'
 import { type IClientOptions } from '../client'
 import type MqttClient from '../client'

src/lib/connect/wx.ts

@@ -1,7 +1,6 @@
-import { type StreamBuilder } from '../shared'
-
 import { Buffer } from 'buffer'
 import { Transform } from 'readable-stream'
+import { type StreamBuilder } from '../shared'
 import { type IClientOptions } from '../client'
 import type MqttClient from '../client'
 import { BufferedDuplex } from '../BufferedDuplex'

src/lib/get-timer.ts

@@ -1,5 +1,5 @@
-import isBrowser, { isWebWorker, isReactNativeBrowser } from './is-browser'
 import { clearInterval as clearI, setInterval as setI } from 'worker-timers'
+import isBrowser, { isWebWorker, isReactNativeBrowser } from './is-browser'
 import type { TimerVariant } from './shared'
 
 // dont directly assign globals to class props otherwise this throws in web workers: Uncaught TypeError: Illegal invocation

src/lib/handlers/connack.ts

@@ -1,7 +1,7 @@
+import { type IConnackPacket } from 'mqtt-packet'
 import { ReasonCodes } from './ack'
 import TopicAliasSend from '../topic-alias-send'
 import { ErrorWithReasonCode, type PacketHandler } from '../shared'
-import { type IConnackPacket } from 'mqtt-packet'
 
 const handleConnack: PacketHandler = (client, packet: IConnackPacket) => {
 	client.log('_handleConnack')

test/node/abstract_client.ts

@@ -5,6 +5,15 @@ import { assert } from 'chai'
 import sinon from 'sinon'
 import fs from 'fs'
 import levelStore from 'mqtt-level-store'
+import {
+	type IPublishPacket,
+	type IPubrelPacket,
+	type ISubackPacket,
+	type QoS,
+} from 'mqtt-packet'
+import { type DoneCallback, ErrorWithReasonCode } from 'src/lib/shared'
+import { fail } from 'assert'
+import { describe, it, beforeEach, afterEach, after } from 'node:test'
 import Store from '../../src/lib/store'
 import serverBuilderFn from './server_helpers_for_client_tests'
 import handlePubrel from '../../src/lib/handlers/pubrel'
@@ -18,15 +27,6 @@ import mqtt, {
 	type ISubscriptionMap,
 	type ISubscriptionRequest,
 } from '../../src'
-import {
-	type IPublishPacket,
-	type IPubrelPacket,
-	type ISubackPacket,
-	type QoS,
-} from 'mqtt-packet'
-import { type DoneCallback, ErrorWithReasonCode } from 'src/lib/shared'
-import { fail } from 'assert'
-import { describe, it, beforeEach, afterEach, after } from 'node:test'
 
 /**
  * These tests try to be consistent with names for servers (brokers) and clients,

test/node/abstract_store.ts

@@ -1,7 +1,7 @@
 import { type IPublishPacket, type IPubrelPacket } from 'mqtt-packet'
-import { type IStore } from '../../src'
 import 'should'
 import { it, beforeEach, afterEach } from 'node:test'
+import { type IStore } from '../../src'
 
 export default function abstractStoreTest(
 	build: (cb: (err?: Error, store?: IStore) => void) => void,

test/node/client.ts

@@ -1,5 +1,4 @@
 import { useFakeTimers } from 'sinon'
-import mqtt from '../../src'
 import { assert } from 'chai'
 import { fork } from 'child_process'
 import path from 'path'
@@ -9,13 +8,14 @@ import mqttPacket from 'mqtt-packet'
 import { Duplex } from 'readable-stream'
 import Connection from 'mqtt-connection'
 import util from 'util'
+import _debug from 'debug'
+import { type IClientOptions } from 'src/lib/client'
+import { describe, it, after } from 'node:test'
 import getPorts from './helpers/port_list'
 import serverBuilder from './server_helpers_for_client_tests'
-import _debug from 'debug'
 import { MqttServer } from './server'
 import abstractClientTests from './abstract_client'
-import { type IClientOptions } from 'src/lib/client'
-import { describe, it, after } from 'node:test'
+import mqtt from '../../src'
 
 // eslint-disable-next-line @typescript-eslint/no-var-requires
 const pkgJson = require('../../package.json')

test/node/client_mqtt5.ts

@@ -1,10 +1,10 @@
 import { assert } from 'chai'
+import { after, describe, it } from 'node:test'
 import abstractClientTests from './abstract_client'
 import { MqttServer } from './server'
 import serverBuilder from './server_helpers_for_client_tests'
 import getPorts from './helpers/port_list'
 import mqtt, { type ErrorWithReasonCode } from '../../src'
-import { after, describe, it } from 'node:test'
 
 const ports = getPorts(1)
 

test/node/keepaliveManager.ts

@@ -1,8 +1,8 @@
 import { afterEach, beforeEach, describe, it } from 'node:test'
-import KeepaliveManager from '../../src/lib/KeepaliveManager'
 import { assert } from 'chai'
 import { useFakeTimers, spy, stub } from 'sinon'
 import { type MqttClient } from 'src'
+import KeepaliveManager from '../../src/lib/KeepaliveManager'
 
 function mockedClient(keepalive: number) {
 	return {

test/node/message-id-provider.ts

@@ -1,6 +1,6 @@
 import { assert } from 'chai'
-import { DefaultMessageIdProvider, UniqueMessageIdProvider } from '../../src'
 import { describe, it } from 'node:test'
+import { DefaultMessageIdProvider, UniqueMessageIdProvider } from '../../src'
 
 describe('message id provider', () => {
 	describe('default', () => {

test/node/mqtt.ts

@@ -1,7 +1,7 @@
 import fs from 'fs'
 import path from 'path'
-import mqtt, { type IClientOptions } from '../../src'
 import { describe, it } from 'node:test'
+import mqtt, { type IClientOptions } from '../../src'
 import 'should'
 
 describe('mqtt', () => {

test/node/mqtt_store.ts

@@ -1,5 +1,5 @@
-import { Store } from '../../src'
 import { describe, it } from 'node:test'
+import { Store } from '../../src'
 import 'should'
 
 describe('store in lib/connect/index.js (webpack entry point)', () => {

test/node/secure_client.ts

@@ -1,11 +1,11 @@
 import path from 'path'
 import fs from 'fs'
+import { assert } from 'chai'
+import { describe, it, after } from 'node:test'
 import mqtt from '../../src'
 import abstractClientTests from './abstract_client'
 import { MqttSecureServer, type MqttServerListener } from './server'
-import { assert } from 'chai'
 import 'should'
-import { describe, it, after } from 'node:test'
 import getPorts from './helpers/port_list'
 
 const ports = getPorts(5)

test/node/server_helpers_for_client_tests.ts

@@ -1,4 +1,3 @@
-import { MqttServer, MqttSecureServer, type MqttServerListener } from './server'
 import _debug from 'debug'
 
 import path from 'path'
@@ -8,6 +7,7 @@ import http from 'http'
 import WebSocket from 'ws'
 import MQTTConnection from 'mqtt-connection'
 import { type Server } from 'net'
+import { MqttServer, MqttSecureServer, type MqttServerListener } from './server'
 
 const KEY = path.join(__dirname, 'helpers', 'tls-key.pem')
 const CERT = path.join(__dirname, 'helpers', 'tls-cert.pem')

test/node/store.ts

@@ -1,6 +1,6 @@
+import { describe } from 'node:test'
 import Store from '../../src/lib/store'
 import abstractTest from './abstract_store'
-import { describe } from 'node:test'
 
 describe('in-memory store', () => {
 	abstractTest(function test(done) {

test/node/unique_message_id_provider_client.ts

@@ -1,8 +1,8 @@
+import { describe, after } from 'node:test'
 import abstractClientTests from './abstract_client'
 import serverBuilder from './server_helpers_for_client_tests'
 import { UniqueMessageIdProvider, type IClientOptions } from '../../src'
 import getPorts from './helpers/port_list'
-import { describe, after } from 'node:test'
 
 const ports = getPorts(3)
 

test/node/websocket_client.ts

@@ -2,11 +2,11 @@ import http from 'http'
 import WebSocket from 'ws'
 import MQTTConnection from 'mqtt-connection'
 import assert from 'assert'
+import { after, describe, it } from 'node:test'
 import abstractClientTests from './abstract_client'
 import getPorts from './helpers/port_list'
 import { MqttServerNoWait } from './server'
 import mqtt, { type IClientOptions } from '../../src'
-import { after, describe, it } from 'node:test'
 
 const ports = getPorts(4)