Skip to content

Remove Nimble 0.22.3 upgrade step from CI workflow - #627

Merged
mratsim merged 1 commit into
masterfrom
nimble-0.22.3
Aug 4, 2026
Merged

Remove Nimble 0.22.3 upgrade step from CI workflow#627
mratsim merged 1 commit into
masterfrom
nimble-0.22.3

Conversation

@mratsim

@mratsim mratsim commented Aug 4, 2026

Copy link
Copy Markdown
Owner

Related

nim-lang/nimble#1636
nim-lang/Nim#25759
nim-lang/Nim#25935

Summary by CodeRabbit

  • Chores
    • Simplified CI workflow by removing a diagnostic step from the build process.

@coderabbitai

coderabbitai Bot commented Aug 4, 2026

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro Plus

Run ID: be1240e4-24ac-472a-afc6-29ccf0b132c6

📥 Commits

Reviewing files that changed from the base of the PR and between ca0006c and e810b4a.

📒 Files selected for processing (1)
  • .github/workflows/ci.yml
💤 Files with no reviewable changes (1)
  • .github/workflows/ci.yml

📝 Walkthrough

Walkthrough

The CI workflow no longer upgrades Nimble to version 0.22.3 or newer. It also no longer prints Nimble diagnostic path information.

Changes

CI workflow cleanup

Layer / File(s) Summary
Remove Nimble upgrade step
.github/workflows/ci.yml
The workflow removes the Nimble installation command and diagnostic output.

Estimated code review effort: 1 (Trivial) | ~3 minutes

Poem

A rabbit watched the workflow run,
No Nimble upgrade under the sun.
The paths stay quiet, the steps are light,
CI hops onward, clean and bright.

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly and concisely describes the removal of the Nimble upgrade step from the CI workflow.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch nimble-0.22.3

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@greptile-apps

greptile-apps Bot commented Aug 4, 2026

Copy link
Copy Markdown

Greptile Summary

Removes the CI step that explicitly upgraded Nimble to version 0.22.3 or newer.

  • Relies on the Nimble version supplied with the configured Nim toolchains.
  • Leaves the existing Nim, Go, Rust, LLVM, and CPU version-reporting step unchanged.

Confidence Score: 5/5

The PR appears safe to merge with no concrete actionable defect identified.

The change only removes an explicit Nimble upgrade workaround, and the available evidence does not establish that any current CI matrix target still receives a Nimble version affected by the upstream issue.

Important Files Changed

Filename Overview
.github/workflows/ci.yml Removes the temporary Nimble upgrade workaround; no concrete current CI failure was established from the available repository evidence.

Reviews (1): Last reviewed commit: "Remove Nimble upgrade step from CI workf..." | Re-trigger Greptile

@mratsim

mratsim commented Aug 4, 2026

Copy link
Copy Markdown
Owner Author

Seems like we have an iterator regression now

================================================================================
||
|| Running #23/131: nim c -r --passC:-fstack-protector-strong  --passC:-D_FORTIFY_SOURCE=3  -d:CTT_ASM=false  --tlsEmulation=off  -d:danger  --panics:on -d:noSignalHandler  --mm:arc -d:useMalloc  --verbosity:0 --hints:off --warnings:off  --passC:-fno-semantic-interposition  --passC:-falign-functions=64  --passC:-fmerge-all-constants --outdir:build/test_suite  --nimcache:nimcache/tests/math_elliptic_curves/t_ec_conversion.nim tests/math_elliptic_curves/t_ec_conversion.nim
||
================================================================================
stack trace: (most recent call last)
/home/runner/work/constantine/constantine/nim-linux-amd64-version-2-2-7a1e162b0ce380730b78fb40088ac4d0df2719b4/lib/system/iterators_1.nim(129, 13) Error: internal error: expr: param not init Iters_587202579
No stack traceback available
To create a stacktrace, rerun compilation with './koch temp c <file>', see https://nim-lang.github.io/Nim/intern.html#debugging-the-compiler for details

========================== Command exited with code 1 ==========================
[FAIL]: 'nim c -r --passC:-fstack-protector-strong  --passC:-D_FORTIFY_SOURCE=3  -d:CTT_ASM=false  --tlsEmulation=off  -d:danger  --panics:on -d:noSignalHandler  --mm:arc -d:useMalloc  --verbosity:0 --hints:off --warnings:off  --passC:-fno-semantic-interposition  --passC:-falign-functions=64  --passC:-fmerge-all-constants --outdir:build/test_suite  --nimcache:nimcache/tests/math_elliptic_curves/t_ec_conversion.nim tests/math_elliptic_curves/t_ec_conversion.nim' (#23/131)
[FAIL]: Command #23 exited with error 1
================================================================================

@mratsim
mratsim merged commit 9e73151 into master Aug 4, 2026
2 of 18 checks passed
@mratsim
mratsim deleted the nimble-0.22.3 branch August 4, 2026 11:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant