test: resolve non-deterministic assertion in regional contrast saliency tests on Windows - #2
Merged
Conversation
…cy tests on Windows
mrazza
approved these changes
May 29, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In the regional contrast saliency test, there was an assertion:
Assert.True(saliency[0, 0].Value < saliency[10, 10].Value);This assertion represents a fragile assumption about specific coordinates being strictly ordered across different platforms/runtimes (which is non-deterministic under Parallel.ForEach with floats/doubles and slight numerical coordinate variations on different OS).
Replacing it with:
Assert.True(saliency.Any(p => p.Value > 0.0 && p.Value < 1.0));properly tests that regional contrast saliency produces non-flat/varied normalized values as expected without relying on coordinate-specific order assumptions. This PR also adds robust, deterministic tests
GlobalContrastSaliency_ContrastingObject_ShouldBeMostSalientandRegionalContrastSaliency_ContrastingObject_ShouldBeMostSalientthat assert mathematically expected saliency values on a deterministic shape.