Skip to content

Optimize Frustum.intersectsBox #14378

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Jun 28, 2018
Merged

Optimize Frustum.intersectsBox #14378

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
1defbe9
Optimize Frustum.intersectsBox
yaoyao-cn Jun 27, 2018
6fbd949
format the code
yaoyao-cn Jun 27, 2018
bfad0e8
format code
yaoyao-cn Jun 27, 2018
4c5ef9e
Merge remote-tracking branch 'upstream/dev' into dev
yaoyao-cn Jun 27, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 6 additions & 14 deletions src/math/Frustum.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -140,8 +140,7 @@ Object.assign( Frustum.prototype, {

intersectsBox: function () {

var p1 = new Vector3(),
p2 = new Vector3();
var p = new Vector3();

return function intersectsBox( box ) {

Expand All @@ -151,19 +150,12 @@ Object.assign( Frustum.prototype, {

var plane = planes[ i ];

p1.x = plane.normal.x > 0 ? box.min.x : box.max.x;
p2.x = plane.normal.x > 0 ? box.max.x : box.min.x;
p1.y = plane.normal.y > 0 ? box.min.y : box.max.y;
p2.y = plane.normal.y > 0 ? box.max.y : box.min.y;
p1.z = plane.normal.z > 0 ? box.min.z : box.max.z;
p2.z = plane.normal.z > 0 ? box.max.z : box.min.z;
//corner at max distance
p.x = plane.normal.x > 0 ? box.max.x : box.min.x;
p.y = plane.normal.y > 0 ? box.max.y : box.min.y;
p.z = plane.normal.z > 0 ? box.max.z : box.min.z;

var d1 = plane.distanceToPoint( p1 );
var d2 = plane.distanceToPoint( p2 );

// if both outside plane, no intersection

if ( d1 < 0 && d2 < 0 ) {
if ( plane.distanceToPoint( p ) < 0 ) {

return false;

Expand Down