Skip to content

WebGPURenderer: Fix textured backgrounds with ortho cameras. #32313

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Nov 19, 2025
Merged

WebGPURenderer: Fix textured backgrounds with ortho cameras. #32313

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
d63a9fb
WebGPURenderer: Fix textured backgrounds with ortho cameras.
Mugen87 Nov 19, 2025
d1e2f17
Try new approach.
Mugen87 Nov 19, 2025
d1eaa05
Clean up.
Mugen87 Nov 19, 2025
50b50f3
Improve comments.
Mugen87 Nov 19, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 16 additions & 2 deletions src/renderers/common/Background.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
import DataMap from './DataMap.js';
import Color4 from './Color4.js';
import { vec4, context, normalWorldGeometry, backgroundBlurriness, backgroundIntensity, backgroundRotation, modelViewProjection } from '../../nodes/TSL.js';
import { vec4, context, normalWorldGeometry, backgroundBlurriness, backgroundIntensity, backgroundRotation, positionLocal, cameraProjectionMatrix, modelViewMatrix, div } from '../../nodes/TSL.js';
import NodeMaterial from '../../materials/nodes/NodeMaterial.js';

import { Mesh } from '../../objects/Mesh.js';
Expand Down Expand Up @@ -94,7 +94,21 @@ class Background extends DataMap {
getTextureLevel: () => backgroundBlurriness
} );

let viewProj = modelViewProjection;
// when using orthographic cameras, we must scale the skybox sphere
// up to exceed the dimensions of the camera's viewing box.
const isOrtho = cameraProjectionMatrix.element( 3 ).element( 3 ).equal( 1.0 );

// calculate the orthographic scale
// projectionMatrix[1][1] is (1 / top). Invert it to get the height and multiply by 3.0
// (an arbitrary safety factor) to ensure the skybox is large enough to cover the corners
// of the rectangular screen
const orthoScale = div( 1.0, cameraProjectionMatrix.element( 1 ).element( 1 ) ).mul( 3.0 );

// compute vertex position
const modifiedPosition = isOrtho.select( positionLocal.mul( orthoScale ), positionLocal );
let viewProj = cameraProjectionMatrix.mul( modelViewMatrix.mul( vec4( modifiedPosition, 1.0 ) ) );

// force background to far plane so it does not occlude objects
viewProj = viewProj.setZ( viewProj.w );

const nodeMaterial = new NodeMaterial();
Expand Down