Doc and examples #7990
Merged
Doc and examples #7990
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Didn't change the link to the source code at the end of docs/api/extras/geometries/LatheGeometry.html.
Yeah. I think I'll will wait for someone to complain. It may be that no one is using it yet. |
|
Thanks! |
Yikes! Complaining. : - ) |
|
😅 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Didn't change the link to the source code at the end of docs/api/extras/geometries/LatheGeometry.html because I don't know if you change those kind of thing during the dev.
By the way, when you cleaned LatheGeometry.js (after #7989), you removed the console.warn when the function is called with an array of Vector3.
The array conversion was maybe to much, but the I think that the console.warn is needed to help people already using LatheGeometry.