✨ Better mouse handling#897
Merged
Merged
Conversation
4 tasks
There was a problem hiding this comment.
Pull request overview
This PR refactors mouse handling in Loop by extracting mouse interaction logic into a dedicated observer class and consolidating radial menu actions into a unified configuration system.
Key Changes:
- Introduced
MouseInteractionObserverto encapsulate mouse event handling previously spread acrossLoopManager - Refactored radial menu actions from individual
Defaultskeys to a single unifiedradialMenuActionsarray usingRadialMenuWindowActionenum - Renamed observer classes from
*Observerto*Triggerfor clarity, and introduced helper classesTriggerDelayTimerandDoubleClickTimer
Reviewed changes
Copilot reviewed 12 out of 15 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| Loop/Extensions/Logger+Extensions.swift | Added convenience initializer for Logger to simplify category-based logging |
| Loop/Extensions/Defaults+Extensions.swift | Consolidated keybind and radial menu defaults to use centralized static properties instead of inline definitions |
| Loop/Core/WindowDragManager.swift | Added @mainactor annotation to addObservers method for thread safety |
| Loop/Core/Observers/MouseInteractionObserver.swift | New class to handle mouse interactions including radial menu navigation and cycle actions |
| Loop/Core/Observers/MiddleClickTrigger.swift | Renamed from MiddleClickObserver for consistency |
| Loop/Core/Observers/KeybindTrigger.swift | Renamed from KeybindObserver, refactored to use shared WindowActionCache |
| Loop/Core/Observers/Helpers/TriggerDelayTimer.swift | New utility class for managing trigger delay timer logic |
| Loop/Core/Observers/Helpers/DoubleClickTimer.swift | New utility class for detecting double-click events |
| Loop/Core/LoopManager.swift | Major refactoring to delegate mouse handling to MouseInteractionObserver and use renamed trigger classes |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
SenpaiHunters
approved these changes
Nov 23, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
MouseInteractionObserverclass that tracks mouse movement and clicks while Loop is active.RadialMenuWindowAction, with two cases:custom, which defines an entirely new action, andkeybindReference, which links to one of the user’s existing keybinds by UUID. This also supports radial-menu customization.WindowActionCacheto include an additional dictionary that can store window actions by either keybind or identifier, speeding up the ID -> action lookup path.