refactor(isoch): make transmit queue payload opaque#76
Merged
Conversation
mrmidi
marked this pull request as ready for review
July 18, 2026 16:05
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Replaces the mixed
IsochAudioTransportshared contract with the ABI-v5, payload-opaqueIsochTxQueue.Audio/where those semantics belong.Why
The former TX control block leaked audio/Wire timing and format semantics into the OHCI transport. That made the transport layer depend on content policy and made later device-family fixes unnecessarily risky. The new seam is payload-opaque and lifetime-owned, matching the completed RX boundary.
Compatibility
No descriptor-layout, queue-size, IIG allocation, or wire-behavior change. The IT channel/descriptor path was cross-checked against the local Linux OHCI reference (
ohci.c:queue_iso_transmit).Validation
ctest --test-dir build/tests_build --output-on-failure— 1,373 passed; six known fixture skips../build.sh --no-bump— succeeds without warnings or errors.Hardware follow-up