feat(backend): wire NotificationService into workflow executor events#3130
Merged
mrveiss merged 1 commit intoDev_new_guifrom Apr 1, 2026
Merged
feat(backend): wire NotificationService into workflow executor events#3130mrveiss merged 1 commit intoDev_new_guifrom
mrveiss merged 1 commit intoDev_new_guifrom
Conversation
…#3101) - WORKFLOW_COMPLETED / WORKFLOW_FAILED sent after _determine_workflow_status - WORKFLOW_FAILED also sent in exception handler - STEP_FAILED sent in _execute_step_with_agent when step result has success=false - Lazy-initialized singleton avoids import cycles - All notification calls are fire-and-forget (logged on failure, never crash workflow) Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
This was referenced Apr 1, 2026
✅ SSOT Configuration Compliance: Passing🎉 No hardcoded values detected that have SSOT config equivalents! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #3101
Summary
NotificationService.send()with appropriateNotificationEventSTEP_FAILEDnotifications immediately after detectionInjection Points
_determine_workflow_status()→WORKFLOW_COMPLETEDorWORKFLOW_FAILEDexecute_coordinated_workflow()→WORKFLOW_FAILED_execute_step_with_agent()whensuccess=false→STEP_FAILEDTest plan
🤖 Generated with Claude Code