fix(backend): load workflow notification_config instead of empty default#3171
Merged
mrveiss merged 1 commit intoDev_new_guifrom Apr 1, 2026
Merged
fix(backend): load workflow notification_config instead of empty default#3171mrveiss merged 1 commit intoDev_new_guifrom
mrveiss merged 1 commit intoDev_new_guifrom
Conversation
#3168) Replace empty NotificationConfig with _resolve_notification_config() that reads notification_config from execution_context. Notifications now only fire when the workflow has a configured notification_config, preventing silent no-ops. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #3168
Summary
_resolve_notification_config()that reads config fromexecution_contextNotificationConfigobjects and raw dicts_send_step_failure_notificationnow receivesexecution_contextfor config lookupRoot Cause
PR #3130 created empty
NotificationConfig(workflow_id=...)with no channels/recipients, so notifications were silently dropped by the service.Test plan
🤖 Generated with Claude Code