Fix deserialization of partial System.Version objects#219
Merged
yfakariya merged 2 commits intomsgpack:masterfrom Mar 26, 2017
Merged
Fix deserialization of partial System.Version objects#219yfakariya merged 2 commits intomsgpack:masterfrom
yfakariya merged 2 commits intomsgpack:masterfrom
Conversation
System.Version can take 2 and 3 parameters, in which case Build and Revision can be assign -1 as an invalid value. In this case, deserialization will fail as -1 is not accepted as a parameter of the constructor taking 4 arguments.
System.Version was not deserializing if the Build or Revision components were not provided in the constructor.
Member
|
Sorry for delay. Thank you for contribution! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi, and thank you for the library !
We are encountering an error when deserializing System.Version objects, because of some weird internals of that class.
System.Version has two partial constructor taking 2 and 3 arguments instead of 4, to only specify part of the Version structure.
When constructing using these Version, will use -1 for the omitted values.
If trying to re-construct such a Version object, providing the -1 value to the full constructor will throw an ArgumentOutOfRange exception.
I added tests for the two additional constructor and fixed the issue by checking what constructor to use depending on the set values.
Thanks!