Skip to content

Fix typo in mpu.exe parameters binding#222

Merged
yfakariya merged 1 commit intomsgpack:masterfrom
kondratov-saritasa:feature/mpu-fixes
Mar 26, 2017
Merged

Fix typo in mpu.exe parameters binding#222
yfakariya merged 1 commit intomsgpack:masterfrom
kondratov-saritasa:feature/mpu-fixes

Conversation

@skondratov
Copy link
Copy Markdown

Hi!

Here is simple typo and also i found one more mpu.exe bug:

I get 'Process is terminated due to StackOverflowException.' when trying to prepare serializer for something like:

   class Example
   {
       public Example[] Childs; 
   } 

I know what it is in this function:

private static IEnumerable<Type> ExtractElementTypes( SerializationContext context, ISerializerGeneratorConfiguration configuration, Type type )

But it is so tangled.. i gave up trying to refactor it. I would completely remove it and write again.. But i need more time to understand the logic. You possibly see less radical solution.

@skondratov
Copy link
Copy Markdown
Author

I suppose build was broken before my changes.

@yfakariya
Copy link
Copy Markdown
Member

I agree the build failure was caused before your commit. I'll fix it soon. Thank you!

@yfakariya yfakariya merged commit 839dc47 into msgpack:master Mar 26, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants