Fix typo in mpu.exe parameters binding#222
Merged
yfakariya merged 1 commit intomsgpack:masterfrom Mar 26, 2017
Merged
Conversation
Author
|
I suppose build was broken before my changes. |
Member
|
I agree the build failure was caused before your commit. I'll fix it soon. Thank you! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi!
Here is simple typo and also i found one more mpu.exe bug:
I get 'Process is terminated due to StackOverflowException.' when trying to prepare serializer for something like:
I know what it is in this function:
msgpack-cli/src/MsgPack/Serialization/SerializerGenerator.cs
Line 498 in 20ae0c3
But it is so tangled.. i gave up trying to refactor it. I would completely remove it and write again.. But i need more time to understand the logic. You possibly see less radical solution.