Skip to content

Use REPLACE mode when converting java string into UTF8. #367

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
xerial merged 2 commits into from
Apr 27, 2016
Merged

Use REPLACE mode when converting java string into UTF8. #367

xerial merged 2 commits into from
Apr 27, 2016

Conversation

@xerial
Copy link
Member

@xerial xerial commented Apr 27, 2016

No description provided.

@frsyuki
Copy link
Member

frsyuki commented Apr 27, 2016

probably better to add a comment like this:

@frsyuki
Copy link
Member

frsyuki commented Apr 27, 2016 

Here sets REPLACE because following exception has happened before:
org.msgpack.core.MessageStringCodingException: java.nio.charset.MalformedInputException: Input length = 1
    at org.msgpack.core.MessagePacker.encodeStringToBufferAt(MessagePacker.java:467) ~[msgpack-core-0.8.6.jar:na]
    at org.msgpack.core.MessagePacker.packString(MessagePacker.java:535) ~[msgpack-core-0.8.6.jar:na]

This happened on JVM 7. But no ideas how to reproduce.

@frsyuki
Copy link
Member

frsyuki commented Apr 27, 2016

Looks good 👍

@xerial xerial merged commit d26aaca into develop Apr 27, 2016
@xerial xerial deleted the use-replace-mode-in-packer branch July 19, 2025 16:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@xerial @frsyuki