Correct cleanup of temporary directories after multiple file uploads - #120
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
Fixes the reported issue where only the last temporary upload directory was cleaned up when multiple files are uploaded in a single request, by tracking and removing all created temp directories.
Changes:
- Track multiple upload temp directories (
tempDirs) and remove them all in thefinalizer. - Replace deprecated
ioutil.TempDir/TempFileusage withos.MkdirTemp/CreateTemp. - Bump
github.com/mattn/go-shellwordsandgithub.com/msoap/raphanusmodule versions.
Reviewed changes
Copilot reviewed 2 out of 3 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| shell2http.go | Track all temp upload directories and clean them up; switch to os.MkdirTemp/CreateTemp. |
| go.mod | Bump dependency versions for go-shellwords and raphanus. |
| go.sum | Update checksums for the bumped dependency versions. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes: #119