allow NULL empty blocks in blk2bstr - #220
Open
rdmark wants to merge 1 commit into
Open
Conversation
Treat a NULL source pointer as valid when len is zero, since no source memory is read and the result is an ordinary empty bstring. Keep negative lengths and NULL pointers paired with a positive length as errors. Document the contract in the public header, and cover the accepted form with the core unit test. Thanks to @DamjanJovanovic for the report
|
Minimum allowed coverage is Generated by 🐒 cobertura-action against 85a5247 |
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



Treat a NULL source pointer as valid when len is zero, since no source memory is read and the result is an ordinary empty bstring. Keep negative lengths and NULL pointers paired with a positive length as errors.
Document the contract in the public header, and cover the accepted form with the core unit test.
Thanks to @DamjanJovanovic for the report