Enhance icon caching and management for Docker containers

[mstrhakr]

This pull request delivers a beta release of Compose Manager Plus, introducing significant new features for stack management, improvements to icon caching, and robust identity enforcement for Docker Compose projects. It also includes several bug fixes, refactorings, and test enhancements to improve reliability and maintainability.

New features and enhancements:

Stack management improvements:

• Added global and per-stack settings for "wait-for-healthy" and configurable timeout, allowing Compose Manager to wait for stacks to report healthy before marking startup as complete. These settings are surfaced in the settings page and respected during stack startup. [1] [2] [3] [4]
• Introduced "follow-logs" functionality, enabling live log streaming during compose up by omitting the detach option.

Identity enforcement and security:

• Mutating actions (like stack updates or deletions) are now blocked unless the stack's project identity is proven, with clear user-facing messages and fail-closed behavior for legacy projects. This is enforced in both manual and scheduled operations. [1] [2] [3] [4] [5] [6]

Icon caching and Docker Manager integration:

• Enhanced icon caching: icons are always served from the plugin cache, with options to refresh and to repair Docker Manager icons. Data URIs are now passed directly to the browser, and cache writes are hardened and atomic. [1] [2] [3]
• Improved icon cache management and test coverage for regression cases.

Bug fixes and refactoring:

UI and dashboard:

• Improved Docker container visibility handling and identity chooser attribute escaping; restored main channel and provided clearer warnings for multi-stack identity errors.
• Extracted dashboard JavaScript and hid Docker flash messages for a cleaner UI.

Chores and documentation:

• Updated changelog, README, and plugin metadata to reflect the beta release and new dev branch pluginURL. [1] [2] [3]

For a full list of changes and details, see the beta release diff.

[Copilot]

🟡 Changes recommended

There are confirmed security/robustness issues in the new identity chooser HTML escaping and in atomic write logic that can spuriously fail due to chmod chaining, plus a potentially unintended update-channel switch in the plugin URL.

Once you've addressed the issues Copilot identified, you can request another Copilot review.

Pull request overview

This PR strengthens Docker container icon handling (cache correctness, atomic writes, Docker Manager cache/metadata repair, shared JS helpers for dashboard + main UI) and adds a fail-closed legacy Compose project-identity migration mechanism that blocks mutating actions until identity is proven or explicitly pinned.

Changes:

• Introduces shared composeIcons.js helpers and aligns Compose page + Dashboard tile icon resolution (including container-context seeding).
• Hardens icon caching: verify PNG bytes, atomic cache writes, stricter cache serving behavior in IconCache.php, and Docker Manager icon/docker.json repair.
• Adds ProjectIdentity resolution + UI affordances (warnings + chooser) and enforces fail-closed behavior across compose actions and auto-update paths, with new regression coverage.

File summaries

File	Description
tests/unit/StackInfoTest.php	Expands icon seeding/repair test coverage and consolidates cleanup.
tests/unit/ProjectIdentityTest.php	Adds regression tests for legacy project-identity resolution and fail-closed behavior.
tests/bootstrap.php	Adds test constants for Docker Manager icon paths and disables live Docker probing by default in tests.
source/compose.manager/README.md	Marks plugin as “(Beta)”.
source/compose.manager/javascript/composeManagerMain.js	Removes inline icon helpers (moved to composeIcons.js) and adds identity-warning UI + identity pinning flow.
source/compose.manager/javascript/composeIcons.js	New shared icon helper module for Compose page + Dashboard tile.
source/compose.manager/include/Util.php	Adds PNG verification/staleness helpers, atomic icon-cache writes, Docker Manager seeding + docker.json repair, and identity integration into StackInfo.
source/compose.manager/include/ProjectIdentity.php	New identity resolver/pinner with Docker evidence probing and fail-closed unresolved state.
source/compose.manager/include/Helpers.php	Blocks mutating compose actions when identity is unresolved; improves multi-action handling for blocked stacks.
source/compose.manager/include/Exec.php	Seeds Docker Manager icons during icon resolution and adds endpoints for identity preview + pinning.
source/compose.manager/include/Defines.php	Adds constants for Docker Manager icon locations and icon-label key.
source/compose.manager/include/ComposeManager.php	Loads composeIcons.js on the Compose page.
source/compose.manager/include/ComposeList.php	Adds identity warning indicators and row data attributes used by the chooser UI.
source/compose.manager/include/ComposeCommandBuilder.php	Refuses mutating compose actions when identity is unresolved (logs allowed).
source/compose.manager/include/AutoUpdateRunner.php	Skips scheduled auto-updates when identity is unresolved.
source/compose.manager/include/AutoUpdate.php	Blocks manual auto-updates with 409 when identity is unresolved.
source/compose.manager/IconCache.php	Serves strictly from cache (with refresh/staleness logic) and supports container-context repairs.
source/compose.manager/compose.manager.dashboard.page	Loads composeIcons.js on dashboard tile and passes container name into icon proxying.
compose.manager.plg	Points pluginURL to the dev branch and tidies changelog formatting.

Review details

Suppressed comments (1)

source/compose.manager/include/Util.php:467

• Docker Manager icon seeding uses a copy/chmod/rename && chain, so a chmod failure prevents seeding even if the copy and rename would have worked. Consider making chmod best-effort (as in other atomic-write patterns) to avoid leaving Docker Manager with a corrupt/missing icon due to permission quirks.

            if (@copy($cachedPngPath, $tmp) && @chmod($tmp, 0644) && @rename($tmp, $dest)) {
                $seeded = true;
                composeLogger('Seeded Docker Manager icon cache', ['container' => $containerName, 'dest' => $dest], 'system', 'debug', 'icon-cache');
            } else {
                @unlink($tmp);

• Files reviewed: 19/19 changed files
• Comments generated: 4
• Review effort level: Lite

---

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

[Copilot]

🟡 Changes recommended

There are confirmed functional and security issues in the new follow-logs path (getopt option list and EXIT trap handling) and in the dashboard/detach endpoints where unescaped or unvalidated inputs can lead to injection or unsafe process signaling.

Once you've addressed the issues Copilot identified, you can request another Copilot review.

Review details

• Files reviewed: 29/29 changed files
• Comments generated: 4
• Review effort level: Lite